Eric Sesterhenn <[email protected]> wrote:
>
> So something like this would be the correct fix for the example?
>
> Fix skb leak found by coverity checker (id #628), skb_put() might
> return a new skb, which gets never freed when we return with
> NETDEV_TX_BUSY. This patch moves the check above the skb_put().
This is bogus. NETDEV_TX_BUSY is meant to requeue the skb.
The real problem is that copying the skb is simply wrong.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
