Re: [PATCH 5/25] msi: Make the msi boolean tests return either 0 or 1.

• To: "Eric W. Biederman" <[email protected]>
• Subject: Re: [PATCH 5/25] msi: Make the msi boolean tests return either 0 or 1.
• From: Jeff Garzik <[email protected]>
• Date: Tue, 20 Jun 2006 18:45:02 -0400
• Cc: Andrew Morton <[email protected]>, [email protected], [email protected], [email protected], [email protected], Ingo Molnar <[email protected]>, Thomas Gleixner <[email protected]>, Andi Kleen <[email protected]>, Natalie Protasevich <[email protected]>, Len Brown <[email protected]>, Kimball Murray <[email protected]>, Brice Goglin <[email protected]>, Greg Lindahl <[email protected]>, Dave Olson <[email protected]>, Greg KH <[email protected]>, Grant Grundler <[email protected]>, "bibo,mao" <[email protected]>, Rajesh Shah <[email protected]>, Mark Maule <[email protected]>, Jesper Juhl <[email protected]>, Shaohua Li <[email protected]>, Matthew Wilcox <[email protected]>, "Michael S. Tsirkin" <[email protected]>, Ashok Raj <[email protected]>, Randy Dunlap <[email protected]>, Roland Dreier <[email protected]>, Tony Luck <[email protected]>
• In-reply-to: <[email protected]>
• References: <[email protected]> <[email protected]> <[email protected]> <[email protected]> <[email protected]> <[email protected]>
• Sender: [email protected]
• User-agent: Thunderbird 1.5.0.4 (X11/20060614)

Eric W. Biederman wrote:

This allows the output of the msi tests to be stored directly
in a bit field.  If you don't do this a value greater than
one will be truncated and become 0.  Changing true to false
with bizare consequences.

Another example of why bit fields are a pain in the butt...

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 0/25] Decouple IRQ issues (MSI, i386, x86_64, ia64)
    • From: [email protected] (Eric W. Biederman)
  • [PATCH 1/25] irq: Convert the move_irq flag from a 32bit word to a single bit
    • From: "Eric W. Biederman" <[email protected]>
  • [PATCH 2/25] irq: Add moved_masked_irq
    • From: "Eric W. Biederman" <[email protected]>
  • [PATCH 3/25] x86_64 irq: Reenable migrating irqs to other cpus.
    • From: "Eric W. Biederman" <[email protected]>
  • [PATCH 4/25] msi: Simplify msi enable and disable.
    • From: "Eric W. Biederman" <[email protected]>
  • [PATCH 5/25] msi: Make the msi boolean tests return either 0 or 1.
    • From: "Eric W. Biederman" <[email protected]>

• Prev by Date: Re: [discuss] Re: [RFC] Whitelist chipsets supporting MSI and check Hyper-transport capabilities
• Next by Date: Re: [RFC, patch] i386: vgetcpu()
• Previous by thread: Re: [PATCH 6/25] msi: Implement helper functions read_msi_msg and write_msi_msg.
• Next by thread: Re: [PATCH 4/25] msi: Simplify msi enable and disable.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]