[PATCH 5/25] msi: Make the msi boolean tests return either 0 or 1.

This allows the output of the msi tests to be stored directly
in a bit field.  If you don't do this a value greater than
one will be truncated and become 0.  Changing true to false
with bizare consequences.

Signed-off-by: Eric W. Biederman <[email protected]>
---
 drivers/pci/msi.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/msi.h b/drivers/pci/msi.h
index 56951c3..9b31d4c 100644
--- a/drivers/pci/msi.h
+++ b/drivers/pci/msi.h
@@ -110,8 +110,8 @@ #define multi_msi_capable(control) \
 	(1 << ((control & PCI_MSI_FLAGS_QMASK) >> 1))
 #define multi_msi_enable(control, num) \
 	control |= (((num >> 1) << 4) & PCI_MSI_FLAGS_QSIZE);
-#define is_64bit_address(control)	(control & PCI_MSI_FLAGS_64BIT)
-#define is_mask_bit_support(control)	(control & PCI_MSI_FLAGS_MASKBIT)
+#define is_64bit_address(control)	(!!(control & PCI_MSI_FLAGS_64BIT))
+#define is_mask_bit_support(control)	(!!(control & PCI_MSI_FLAGS_MASKBIT))
 #define msi_enable(control, num) multi_msi_enable(control, num); \
 	control |= PCI_MSI_FLAGS_ENABLE
 
-- 
1.4.0.gc07e

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 5/25] msi: Make the msi boolean tests return either 0 or 1.
    • From: Jeff Garzik <[email protected]>
  • [PATCH 6/25] msi: Implement helper functions read_msi_msg and write_msi_msg.
    • From: "Eric W. Biederman" <[email protected]>

• References:
  • [PATCH 0/25] Decouple IRQ issues (MSI, i386, x86_64, ia64)
    • From: [email protected] (Eric W. Biederman)
  • [PATCH 1/25] irq: Convert the move_irq flag from a 32bit word to a single bit
    • From: "Eric W. Biederman" <[email protected]>
  • [PATCH 2/25] irq: Add moved_masked_irq
    • From: "Eric W. Biederman" <[email protected]>
  • [PATCH 3/25] x86_64 irq: Reenable migrating irqs to other cpus.
    • From: "Eric W. Biederman" <[email protected]>
  • [PATCH 4/25] msi: Simplify msi enable and disable.
    • From: "Eric W. Biederman" <[email protected]>

• Prev by Date: [PATCH 3/25] x86_64 irq: Reenable migrating irqs to other cpus.
• Next by Date: [PATCH 13/25] msi: Make the msi code irq based and not vector based.
• Previous by thread: [PATCH 4/25] msi: Simplify msi enable and disable.
• Next by thread: [PATCH 6/25] msi: Implement helper functions read_msi_msg and write_msi_msg.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]