Re: [PATCH] clean tty fields on failed device open

On Wed, 14 Jun 2006 13:52:30 +0200
Frank Gevaerts <[email protected]> wrote:

| On Tue, Jun 13, 2006 at 02:45:12PM -0300, Luiz Fernando N. Capitulino wrote:
| >  Could you redo and submit please?
| 
| OK. Here it is:
| 
| Fixes a BUG on disconnect. gregkh-usb-usb-rmmod-pl2303-after-28.patch (from -mm trees)
| is also needed to fix all problems.

 Hmm, I'd prefer something like this:

"""
If either the driver's open() method or try_module_get() fails, we need to
set 'tty->driver_data' and 'port->tty' to NULL in serial_open(), otherwise
we'll get an OOPS in usb_device_disconnect() when the device is disconnected.
"""

-- 
Luiz Fernando N. Capitulino
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH] clean tty fields on failed device open
  - From: Frank Gevaerts <[email protected]>

References:
- Re: pl2303 ttyUSB0: pl2303_open - failed submitting interrupt urb, error -28
  - From: Mark Lord <[email protected]>
- pl2303 ttyUSB0: pl2303_open - failed submitting interrupt urb, error -28
  - From: Mark Lord <[email protected]>
- Re: pl2303 ttyUSB0: pl2303_open - failed submitting interrupt urb, error -28
  - From: Greg KH <[email protected]>
- Re: pl2303 ttyUSB0: pl2303_open - failed submitting interrupt urb, error -28
  - From: Mark Lord <[email protected]>
- Re: pl2303 ttyUSB0: pl2303_open - failed submitting interrupt urb, error -28
  - From: Greg KH <[email protected]>
- Re: pl2303 ttyUSB0: pl2303_open - failed submitting interrupt urb, error -28
  - From: Mark Lord <[email protected]>
- Re: pl2303 ttyUSB0: pl2303_open - failed submitting interrupt urb, error -28
  - From: Mark Lord <[email protected]>
- Re: pl2303 ttyUSB0: pl2303_open - failed submitting interrupt urb, error -28
  - From: Frank Gevaerts <[email protected]>
- Re: pl2303 ttyUSB0: pl2303_open - failed submitting interrupt urb, error -28
  - From: "Luiz Fernando N. Capitulino" <[email protected]>
- Re: pl2303 ttyUSB0: pl2303_open - failed submitting interrupt urb, error -28
  - From: "Luiz Fernando N. Capitulino" <[email protected]>
- [PATCH] clean tty fields on failed device open
  - From: Frank Gevaerts <[email protected]>

Prev by Date: Re: [PATCH 2.6.17-rc6 7/9] Remove some of the kmemleak false positives
Next by Date: Re: [PATCH] clean tty fields on failed device open
Previous by thread: [PATCH] clean tty fields on failed device open
Next by thread: Re: [PATCH] clean tty fields on failed device open
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]