Re: 2.6.17-rc5-mm3: bad unlock ordering (reiser4?)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ingo Molnar wrote:

>        if (atomic_read(&node->d_count) != 0) {
>                return 0;
>        }
>
>why the braces, when on the next line it's not done:
>
>        if (blocknr_is_fake(jnode_get_block(node)))
>                return 0;
>
>it looks quite inconsistent.
>
I have a (roughly adhered to) rule that I don't hassle programmers much
about the style of any code that I can easily read.  I truly do not care
where the braces are, I care if the comments and variable names are well
done.  So that is why, and yes, I know I am an unusual manager on this
point.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux