Re: [PATCH] fix generic HDLC synclink mismatch build error

Hi,

On Fri, 9 Jun 2006, Paul Fulghum wrote:

> Roman Zippel wrote:
> > > +config SYNCLINK_HDLC
> > > +	bool "Generic HDLC support for SyncLink driver"
> > > +	depends on SYNCLINK
> > > +	depends on HDLC=y || HDLC=SYNCLINK
> > 
> > 
> > If you replace now 'bool "..."' with 'def_bool y', it's enabled
> > automatically as soon as HDLC is enabled and the user doesn't has to confirm
> > it for every driver separately and it has the same effect as your #ifdef
> > hack.
> 
> You need to explain this more.

Just try it. :)

> The only #ifdef in the patch is that which conditionally
> compiles the generic HDLC support based on the
> kernel configuration option. If I remove those, then
> the synclink would require generic HDLC, which
> is not what we want.

I meant the old #ifdef hack, which your patch removed.

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] fix generic HDLC synclink mismatch build error
    • From: Paul Fulghum <[email protected]>

• References:
  • [PATCH] fix generic HDLC synclink mismatch build error
    • From: Paul Fulghum <[email protected]>
  • Re: [PATCH] fix generic HDLC synclink mismatch build error
    • From: "Randy.Dunlap" <[email protected]>
  • [PATCH] fix generic HDLC synclink mismatch build error
    • From: Paul Fulghum <[email protected]>
  • Re: [PATCH] fix generic HDLC synclink mismatch build error
    • From: Roman Zippel <[email protected]>
  • Re: [PATCH] fix generic HDLC synclink mismatch build error
    • From: Paul Fulghum <[email protected]>

• Prev by Date: Re: [Ext2-devel] [RFC 0/13] extents and 48bit ext3
• Next by Date: [PATCH 0/1] vfs: support for COW files in sys_open: resend
• Previous by thread: Re: [PATCH] fix generic HDLC synclink mismatch build error
• Next by thread: Re: [PATCH] fix generic HDLC synclink mismatch build error
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]