Re: [PATCH] fix generic HDLC synclink mismatch build error

["Randy.Dunlap" <rdunlap@xenotime.net>]

On Wed, 07 Jun 2006 10:42:58 -0500 Paul Fulghum wrote:

> Fix build errors caused by generic HDLC
> and synclink configuration mismatch. Generic HDLC
> symbols referenced from synclink drivers do not
> resolve if synclink drivers are built-in and generic
> HDLC is modularized.
> 
> kbuild depends statement to demote synclink can't be
> used because generic HDLC support is optional for
> synclink driver

See my new patch below.  All done in Kconfig, no
source file changes needed.  Highly preferable. :)

> kbuild select statement to promote generic HDLC can't
> be used because some kernel developers consider it
> ugly and believe it should never be used
> (so I surrender to the flow)
> 
> The last remaining alternative suppresses inclusion
> of generic HDLC support in the synclink drivers if
> the kernel configuration has synclink built-in and
> generic HDLC modularized.

---
From: Randy Dunlap <rdunlap@xenotime.net>

Fix missing symbol references to hdlc_generic functions.
Switch SYNCLINK drivers from using SELECT to using DEPENDS for HDLC.
However, the DEPENDS values must be restricted to the value
of HDLC (y or m).

Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
 drivers/char/Kconfig        |    6 +++---
 drivers/char/pcmcia/Kconfig |    2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

--- linux-2617-rc5mm3.orig/drivers/char/Kconfig
+++ linux-2617-rc5mm3/drivers/char/Kconfig
@@ -197,7 +197,6 @@ config ISI
 config SYNCLINK
 	tristate "SyncLink PCI/ISA support"
 	depends on SERIAL_NONSTANDARD && PCI && ISA_DMA_API
-	select HDLC if SYNCLINK_HDLC
 	help
 	  Driver for SyncLink ISA and PCI synchronous serial adapters.
 	  These adapters are no longer in production and have
@@ -206,6 +205,7 @@ config SYNCLINK
 config SYNCLINK_HDLC
 	bool "Generic HDLC support for SyncLink driver"
 	depends on SYNCLINK
+	depends on HDLC=y || HDLC=SYNCLINK
 	help
 	  Enable generic HDLC support for the SyncLink PCI/ISA driver.
 	  Generic HDLC implements multiple higher layer networking
@@ -214,7 +214,6 @@ config SYNCLINK_HDLC
 config SYNCLINKMP
 	tristate "SyncLink Multiport support"
 	depends on SERIAL_NONSTANDARD && PCI
-	select HDLC if SYNCLINKMP_HDLC
 	help
 	  Driver for SyncLink Multiport (2 or 4 ports) PCI synchronous serial adapter.
 	  These adapters are no longer in production and have
@@ -223,6 +222,7 @@ config SYNCLINKMP
 config SYNCLINKMP_HDLC
 	bool "Generic HDLC support for SyncLink Multiport"
 	depends on SYNCLINKMP
+	depends on HDLC=y || HDLC=SYNCLINKMP
 	help
 	  Enable generic HDLC support for the SyncLink Multiport driver.
 	  Generic HDLC implements multiple higher layer networking
@@ -231,7 +231,6 @@ config SYNCLINKMP_HDLC
 config SYNCLINK_GT
 	tristate "SyncLink GT/AC support"
 	depends on SERIAL_NONSTANDARD && PCI
-	select HDLC if SYNCLINK_GT_HDLC
 	help
 	  Support for SyncLink GT and SyncLink AC families of
 	  synchronous and asynchronous serial adapters
@@ -240,6 +239,7 @@ config SYNCLINK_GT
 config SYNCLINK_GT_HDLC
 	bool "Generic HDLC support for SyncLink GT/AC"
 	depends on SYNCLINK_GT
+	depends on HDLC=y || HDLC=SYNCLINK_GT
 	help
 	  Enable generic HDLC support for the SyncLink GT/AC driver.
 	  Generic HDLC implements multiple higher layer networking
--- linux-2617-rc5mm3.orig/drivers/char/pcmcia/Kconfig
+++ linux-2617-rc5mm3/drivers/char/pcmcia/Kconfig
@@ -8,13 +8,13 @@ menu "PCMCIA character devices"
 config SYNCLINK_CS
 	tristate "SyncLink PC Card support"
 	depends on PCMCIA
-	select HDLC if SYNCLINK_CS_HDLC
 	help
 	  Driver for SyncLink PC Card synchronous serial adapter.
 
 config SYNCLINK_CS_HDLC
 	bool "Generic HDLC support for SyncLink Multiport"
 	depends on SYNCLINK_CS
+	depends on HDLC=y || HDLC=SYNCLINK_CS
 	help
 	  Enable generic HDLC support for the SyncLink PC Card driver.
 	  Generic HDLC implements multiple higher layer networking
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/