Re: [PATCH] fix missing hdlc symbols for synclink drivers

[Paul Fulghum <paulkf@microgate.com>]

On Tue, 2006-06-06 at 17:12 -0700, Randy.Dunlap wrote:
> They are random in the sense that HDLC depends on WAN but only
> HDLC was being selected.  In theory I would have expected
> config (software) to automatically enable higher-level config
> symbols in this case (select HDLC to cause select WAN),
> but that doesn't happen

I absolutely agree, that is the way I thought it would work
as all the information to build correctly is contained in the
Kconfig files.

But, as you say, kbuild does not work that way.
Changing kbuild to do that would take more time than
I can commit, so I don't have any room to complain about it.

> , so we got some "random" config
> which isn't supported (or even valid) ("random" being "invalid"
> in this case).

Yes, the config is random, but the select statements are
specifically chosen to work with the existing kbuild.
Bottom line is the existing kbuild does not seem to
propagate reverse dependencies, so you have to explicitly
add them all with the select facility. Ugly, but not random.

In the end, it is your original patch (select WAN minus the Makefile
changes) that makes it work.

BTW: Thanks for spending your time on this (Randy and Krzysztof),
the exchange has been educational and useful.

--
Paul



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/