Re: [PATCH] fix missing hdlc symbols for synclink drivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 06 Jun 2006 18:56:51 -0500 Paul Fulghum wrote:

> On Wed, 2006-06-07 at 01:37 +0200, Krzysztof Halasa wrote:
> > "Randy.Dunlap" <[email protected]> writes:
> > 
> > > I'm on x86-64 if it matters.
> > > My .config is attached.
> > 
> > Ok, reproduced.
> > 
> > The problem is that CONFIG_WAN is not set, the make system doesn't
> > read drivers/net/wan/Makefile at all, and nothing in drivers/net/wan
> > is being built.
> > 
> > Just another argument against random SELECTs.
> 
> OK, I thought he was building with the latest patch (attached here),
> which adds the 'select WAN' reverse dependency.
> I tested his .config with the patch (minus the Makefile portion) and
> it builds just fine.

No, I wasn't using any patches...

> There is nothing random about these select statements.
> They are chosen specifically to fix the dependencies.
> You may feel they are ugly, but 'select' is the only tool
> I know of that fixes these errors without losing flexibility.

They are random in the sense that HDLC depends on WAN but only
HDLC was being selected.  In theory I would have expected
config (software) to automatically enable higher-level config
symbols in this case (select HDLC to cause select WAN),
but that doesn't happen, so we got some "random" config
which isn't supported (or even valid) ("random" being "invalid"
in this case).


> --- linux-2.6.17-rc5-mm3/drivers/char/Kconfig	2006-06-06 14:03:58.000000000 -0500
> +++ b/drivers/char/Kconfig	2006-06-06 14:08:53.000000000 -0500
> @@ -197,6 +197,7 @@ config ISI
>  config SYNCLINK
>  	tristate "SyncLink PCI/ISA support"
>  	depends on SERIAL_NONSTANDARD && PCI && ISA_DMA_API
> +	select WAN if SYNCLINK_HDLC
>  	select HDLC if SYNCLINK_HDLC
>  	help
>  	  Driver for SyncLink ISA and PCI synchronous serial adapters.
> @@ -214,6 +215,7 @@ config SYNCLINK_HDLC
>  config SYNCLINKMP
>  	tristate "SyncLink Multiport support"
>  	depends on SERIAL_NONSTANDARD && PCI
> +	select WAN if SYNCLINKMP_HDLC
>  	select HDLC if SYNCLINKMP_HDLC
>  	help
>  	  Driver for SyncLink Multiport (2 or 4 ports) PCI synchronous serial adapter.
> @@ -231,6 +233,7 @@ config SYNCLINKMP_HDLC
>  config SYNCLINK_GT
>  	tristate "SyncLink GT/AC support"
>  	depends on SERIAL_NONSTANDARD && PCI
> +	select WAN if SYNCLINK_GT_HDLC
>  	select HDLC if SYNCLINK_GT_HDLC
>  	help
>  	  Support for SyncLink GT and SyncLink AC families of
> --- linux-2.6.17-rc5-mm3/drivers/char/pcmcia/Kconfig	2006-06-06 14:03:58.000000000 -0500
> +++ b/drivers/char/pcmcia/Kconfig	2006-06-06 14:09:25.000000000 -0500
> @@ -8,6 +8,7 @@ menu "PCMCIA character devices"
>  config SYNCLINK_CS
>  	tristate "SyncLink PC Card support"
>  	depends on PCMCIA
> +	select WAN if SYNCLINK_CS_HDLC
>  	select HDLC if SYNCLINK_CS_HDLC
>  	help
>  	  Driver for SyncLink PC Card synchronous serial adapter.


---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux