Re: [PATCH] fix missing hdlc symbols for synclink drivers

[Paul Fulghum <paulkf@microgate.com>]

Randy.Dunlap wrote:
> On Tue, 06 Jun 2006 23:09:42 +0200 Krzysztof Halasa wrote:
> > I.e., I would probably change:
> >
> > #ifdef CONFIG_HDLC_MODULE
> > #define CONFIG_HDLC 1
> > #endif

These macros have already been replaced in the synclink drivers.

> So SYNCLINK has different capabilities depending on whether
> HDLC=m or HDLC=y ??

No, the current situation is generic HDLC support is
an optional configuration for the synclink drivers.
The build option of generic HDLC must match that
of the synclink driver if that option is enabled.

if synclink is 'y' with generic HDLC option enabled,
then the generic HDLC module must be 'y'

if synclink is 'm' with generic HDLC option enabled,
then generic HDLC can be 'y' or 'm'

if synclink is 'y' or 'm' without the generic HDLC option,
then it is not necessary to build/load the generic HDLC module

--

The Kconfig addition of 'select WAN if SYNCLINK_XX_HDLC'
enables the above behavior.

I thought the Makefile change was to allow generic HDLC
to build as a module. I'll need to look at that closer.

--
Paul
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/