Paul Fulghum <[email protected]> writes:
> If I took that approach then you could never
> use the synclink drivers without generic HDLC.
>
> The synclink drivers can be used independent of
> the generic HDLC or with generic HDLC depending
> on space requirements and application.
Ah, now I understand. Anyway, the Makefile is not related to the problem.
> If you can provide a patch that continues allowing
> that level of flexibility in a way more to
> your liking, then please post it and I'll have a look.
I think I would modify the conditionals in drivers/char/synclink.c
- to assume that generic HDLC is not present if CONFIG_SYNCLINK=y
and CONFIG_HDLC=m. I would even put a user-visible comment in the
*config (like the one in generic HDLC menu if you have no X.25/LAPB).
I.e., I would probably change:
#ifdef CONFIG_HDLC_MODULE
#define CONFIG_HDLC 1
#endif
into something like:
#if defined(CONFIG_HDLC_MODULE) && defined(CONFIG_SYNCLINK_MODULE)
#define CONFIG_HDLC 1
#endif
plus that comment in Kconfig.
(Not sure if the other synclink*.c files are relevant and need similar
changes).
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
