Re: [Patch] Check sound_alloc_mixerdev() failure in sound/oss/nm256_audio.c

hi,

> > -    if (num_mixers >= MAX_MIXER_DEV) {
> > +    if ((num_mixers >= MAX_MIXER_DEV) || (num_mixers < 0)) {
> 					     ^^^^^^^^^^
> >  	printk ("NM256 mixer: Unable to alloc mixerdev\n");
> >  	return -1;
> >      }
> 
> But it is _still_ fails to check it.

*yuck* I hope you keep count on the numbers of beers i owe you
by now. Here is an updated patch.

Signed-off-by: Eric Sesterhenn <[email protected]>

--- linux-2.6.17-rc5/sound/oss/nm256_audio.c.orig	2006-06-05 20:15:18.000000000 +0200
+++ linux-2.6.17-rc5/sound/oss/nm256_audio.c	2006-06-05 20:16:06.000000000 +0200
@@ -974,7 +974,7 @@ nm256_install_mixer (struct nm256_info *
 	return -1;
 
     mixer = sound_alloc_mixerdev();
-    if (num_mixers >= MAX_MIXER_DEV) {
+    if ((num_mixers >= MAX_MIXER_DEV) || (mixer < 0)) {
 	printk ("NM256 mixer: Unable to alloc mixerdev\n");
 	return -1;
     }


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [Patch] Check sound_alloc_mixerdev() failure in sound/oss/nm256_audio.c
    • From: Eric Sesterhenn <[email protected]>
  • Re: [Patch] Check sound_alloc_mixerdev() failure in sound/oss/nm256_audio.c
    • From: Alexey Dobriyan <[email protected]>

• Prev by Date: Re: header cleanup and install
• Next by Date: Re: 2.6.17-rc5-mm1
• Previous by thread: Re: [Patch] Check sound_alloc_mixerdev() failure in sound/oss/nm256_audio.c
• Next by thread: [patch 0/5] [PATCH,RFC] vfs: per-superblock unused dentries list (2nd version)
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]