[Patch] Check sound_alloc_mixerdev() failure in sound/oss/nm256_audio.c

hi,

this was spotted by coverity, bug id #395.
When sound_alloc_mixerdev() fails it returns a
negative value, which the driver fails to check.

Signed-off-by: Eric Sesterhenn <[email protected]>

--- linux-2.6.17-rc5/sound/oss/nm256_audio.c.orig	2006-06-01 11:49:23.000000000 +0200
+++ linux-2.6.17-rc5/sound/oss/nm256_audio.c	2006-06-01 11:49:57.000000000 +0200
@@ -974,7 +974,7 @@ nm256_install_mixer (struct nm256_info *
 	return -1;
 
     mixer = sound_alloc_mixerdev();
-    if (num_mixers >= MAX_MIXER_DEV) {
+    if ((num_mixers >= MAX_MIXER_DEV) || (num_mixers < 0)) {
 	printk ("NM256 mixer: Unable to alloc mixerdev\n");
 	return -1;
     }


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [Patch] Check sound_alloc_mixerdev() failure in sound/oss/nm256_audio.c
    • From: Alexey Dobriyan <[email protected]>

• Prev by Date: Re: 2.6.17-rc5-mm2
• Next by Date: Re: broadcom 5752 in HP dc7600U works on 2.6.13 but does not working on 2.6.16
• Previous by thread: io apic and shared irq questions
• Next by thread: Re: [Patch] Check sound_alloc_mixerdev() failure in sound/oss/nm256_audio.c
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]