Re: [patch] fix smt nice lock contention and optimization

[Con Kolivas <kernel@kolivas.org>]

On Saturday 03 June 2006 17:43, Chen, Kenneth W wrote:
> OK, final rolled up patch with everyone's changes. I fixed one bug
> introduced by Con's earlier patch that there is an unpaired
> spin_trylock/spin_unlock in the for loop of dependent_sleeper().
> Chris, Con, Nick - please review and provide your signed-off-by line.
> Andrew - please consider for -mm inclusion.  Thanks.

Looks good. Just one style nitpick.

>  	for_each_domain(this_cpu, tmp)
> -		if (tmp->flags & SD_SHARE_CPUPOWER)
> +		if (tmp->flags & SD_SHARE_CPUPOWER) {
>  			sd = tmp;
> -
> +			break;
> +		}

Could we make this neater with extra braces such as:

 	for_each_domain(this_cpu, tmp) {
		if (tmp->flags & SD_SHARE_CPUPOWER) {
 			sd = tmp;
			break;
		}
	}

and same for the other uses of for_each ? I know it's redundant but it's 
neater IMO when there are multiple lines of code below it.

-- 
-ck
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/