Re: 2.6.17-rc5-mm1 - output of lock validator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Andrew Morton wrote:
Arjan van de Ven <[email protected]> wrote:
Andrew Morton wrote:
On Wed, 31 May 2006 16:28:59 +0200
Arjan van de Ven <[email protected]> wrote:

--- linux-2.6.17-rc5-mm1.5.orig/drivers/net/8390.c
+++ linux-2.6.17-rc5-mm1.5/drivers/net/8390.c
@@ -299,7 +299,7 @@ static int ei_start_xmit(struct sk_buff disable_irq_nosync(dev->irq);
 	
-	spin_lock(&ei_local->page_lock);
+	spin_lock_irqsave(&ei_local->page_lock, flags);
Again, notabug - we did disable_irq().
but does disable_irq() work in the light of that irqpoll stuff?


Don't have a clue what you're referring to, sorry.

misrouted_irq() in kernel/irq/spurious.c
afaics that calls all handlers registered to the system regardless of what
irq number they are registered for.....

which breaks the disable_irq() locking trick... because your irq handler now
gets called anyway!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux