Re: [PATCH-2.4] forcedeth update to 0.50

Marcelo Tosatti wrote:

Since v2.4.33 should be out RSN, my opinion is that applying the one-liner to fix the bringup problem for now is more prudent..

It's attached. Untested, but it should work. Just the relevant hunk from the 0.42 patch.

But I would disagree with waiting for 2.3.34 for a full backport:

0.30 basically doesn't work, thus the update to 0.50 would be a big step forward - it can't be worse that 0.30.

--
   Manfred

--- 2.6/drivers/net/forcedeth.c	2005-08-14 11:17:03.000000000 +0200
+++ build-2.6/drivers/net/forcedeth.c	2005-08-14 11:16:53.000000000 +0200
@@ -2178,6 +2180,9 @@
 		writel(NVREG_MIISTAT_MASK, base + NvRegMIIStatus);
 		dprintk(KERN_INFO "startup: got 0x%08x.\n", miistat);
 	}
+	/* set linkspeed to invalid value, thus force nv_update_linkspeed
+	 * to init hw */
+	np->linkspeed = 0;
 	ret = nv_update_linkspeed(dev);
 	nv_start_rx(dev);
 	nv_start_tx(dev);

---

• Follow-Ups:
  • Re: [PATCH-2.4] forcedeth update to 0.50
    • From: Willy Tarreau <[email protected]>

• References:
  • [PATCH-2.4] forcedeth update to 0.50
    • From: Willy Tarreau <[email protected]>
  • Re: [PATCH-2.4] forcedeth update to 0.50
    • From: Manfred Spraul <[email protected]>
  • Re: [PATCH-2.4] forcedeth update to 0.50
    • From: Willy Tarreau <[email protected]>
  • Re: [PATCH-2.4] forcedeth update to 0.50
    • From: Marcelo Tosatti <[email protected]>

• Prev by Date: Re: 2.6.17-rc5-mm1 - output of lock validator
• Next by Date: Re: OpenGL-based framebuffer concepts
• Previous by thread: Re: [PATCH-2.4] forcedeth update to 0.50
• Next by thread: Re: [PATCH-2.4] forcedeth update to 0.50
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]