Re: [patch 2/3] vdso: improve print_fatal_signals support by adding memory maps

[Ingo Molnar <mingo@elte.hu>]

* Zachary Amsden <zach@vmware.com> wrote:

> >+	if (current->mm)
> >+		printk("vDSO at %p\n", current->mm->context.vdso);
> >+#endif
> > 	show_regs(regs);
> >+	printk("\n");
> >+	print_vmas();
> > }
> > 
> > static int __init setup_print_fatal_signals(char *str
> 
> Perhaps I should have read your first patch more carefully - it did 
> have register info.  This looks even better (although you may now want 
> to allow it to be #ifdef'd out under CONFIG_EMBEDDED).
> 
> You probably should use PATH_MAX+1 instead of SIZE or check IS_ERR() 
> on the string from d_path.

the string is constructed on the stack, so 4K would be too much. 128 is 
i think enough for most purposes.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/