Re: [Patch 3/6] statistics infrastructure - prerequisite: timestamp

Balbir Singh wrote:

+static inline int nsec_to_timestamp(char *s, unsigned long long t)
+{
+       unsigned long nsec_rem = do_div(t, 1000000000);

Could we please use NSEC_PER_SEC. I cannot count the number of zeros
after the 1.

Sure. I tried to keep my changes as small as possible ;-)

+ return sprintf(s, "[%5lu.%06lu]", (unsigned long)t, nsec_rem/1000);

+}

Something symbolic for the 1000 would be better.  NSECS_PER_USEC probably?

Makes sense.

Thanks,
Martin


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [Patch 3/6] statistics infrastructure - prerequisite: timestamp
    • From: Martin Peschke <[email protected]>
  • Re: [Patch 3/6] statistics infrastructure - prerequisite: timestamp
    • From: "Balbir Singh" <[email protected]>

• Prev by Date: Re: [PATCH] Re: usb-serial ipaq kernel problem
• Next by Date: Re: Linux Kernel Source Compression
• Previous by thread: Re: [Patch 3/6] statistics infrastructure - prerequisite: timestamp
• Next by thread: Re: [Patch 3/6] statistics infrastructure - prerequisite: timestamp
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]