Re: [PATCH 5/6, 2nd try] reliable stack trace support (i386)

["Jan Beulich" <jbeulich@novell.com>]

>>> Andi Kleen <ak@suse.de> 22.05.06 16:13 >>>
>On Monday 22 May 2006 15:18, Jan Beulich wrote:
>> These are the i386-specific pieces to enable reliable stack traces. This is
>> going to be even more useful once CFI annotations get added to he assembly
>> code, namely to entry.S.
>
>Also obsolete with 6/6? 

Yes, but I thought this basically just says that.

>> +#ifdef CONFIG_STACK_UNWIND
>> +  . = ALIGN(4);
>> +  .eh_frame : AT(ADDR(.eh_frame) - LOAD_OFFSET) {
>> +	__start_unwind = .;
>> +  	*(.eh_frame)
>> +	__end_unwind = .;
>> +  }
>> +#endif
>
>Shouldn't this be CONFIG_UNWIND_INFO?  Seems a bit unsymmetric to x86-64

It's exactly the same xor x86-64 - the added symbols (__start_unwind and __end_unwind) are only needed then. Of course,
there wouldn't be anything wrong if one used CONFIG_UNWIND_INFO here.

>I merged the patches all up for now. Thanks.

Thanks!

Jan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/