Re: [PATCH] rtc subsystem, use ENOIOCTLCMD where appropriate

Ingo Oeser wrote:

Hi Hans Peter,

H. Peter Anvin wrote

ENOIOCTLCMD is right here, *except* in the very last hunk, because
it's a request to the upper layers to emulate the operation:

So would a patch like this be welcome and clear this up?

diff --git a/include/linux/errno.h b/include/linux/errno.h
index d90b80f..d33ae4b 100644
--- a/include/linux/errno.h
+++ b/include/linux/errno.h
@@ -9,7 +9,7 @@
 #define ERESTARTSYS	512
 #define ERESTARTNOINTR	513
 #define ERESTARTNOHAND	514	/* restart if no handler.. */
-#define ENOIOCTLCMD	515	/* No ioctl command */
+#define ENOIOCTLCMD	515	/* No ioctl command, upper layer please emulate or pass ENOTTY to user space */
 #define ERESTART_RESTARTBLOCK 516 /* restart by calling sys_restart_syscall */

/* Defined for the NFSv3 protocol */

Sure, if people feel it's necessary.

	-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] rtc subsystem, use ENOIOCTLCMD where appropriate
    • From: Alessandro Zummo <[email protected]>
  • Re: [PATCH] rtc subsystem, use ENOIOCTLCMD where appropriate
    • From: Alessandro Zummo <[email protected]>
  • Re: [PATCH] rtc subsystem, use ENOIOCTLCMD where appropriate
    • From: "H. Peter Anvin" <[email protected]>
  • Re: [PATCH] rtc subsystem, use ENOIOCTLCMD where appropriate
    • From: Ingo Oeser <[email protected]>

• Prev by Date: Re: [PATCH] rtc subsystem, use ENOIOCTLCMD where appropriate
• Next by Date: Re: [PATCH] sector_t overflow in block layer
• Previous by thread: Re: [PATCH] rtc subsystem, use ENOIOCTLCMD where appropriate
• Next by thread: [patch 00/50] genirq: -V3
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]