Re: [patch 9/9] Add bcm43xx HW RNG support

On Fri, 2006-05-12 at 18:16 +0300, Denis Vlasenko wrote:

> Didn't you mean
> 
> 	*(u16*)data = bcm43xx_read16(bcm, BCM43xx_MMIO_RNG); ?
> 
> > +	bcm43xx_unlock(bcm, flags);
> > +
> > +	return (sizeof(u16));
> > +}

I'm not the expert, but looking at patch 2 I'd say no, because one byte
is copied out and then the value is right-shifted, so it is always
treated as a u32 where only 'size' bytes are valid starting with the
lower bytes.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part

---

• References:
  • [patch 0/9] New Generic HW RNG (#3)
    • From: [email protected]
  • [patch 9/9] Add bcm43xx HW RNG support
    • From: [email protected]
  • Re: [patch 9/9] Add bcm43xx HW RNG support
    • From: Denis Vlasenko <[email protected]>

• Prev by Date: Re: www.softpanorama.org: sparc_vs_x86 fun
• Next by Date: 2.6.17-rc4 new perfmon code base + libpfm available
• Previous by thread: Re: [patch 9/9] Add bcm43xx HW RNG support
• Next by thread: Re: [patch 9/9] Add bcm43xx HW RNG support
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]