On Mon, 8 May 2006, Christoph Lameter wrote:
>
> On Mon, 8 May 2006, Pekka Enberg wrote:
>
> > > I think it sounds like it's worth it, but I'm not going to really push it.
> >
> > Sounds good to me. Andrew?
>
> virt_to_page is not cheap on NUMA.
Right now the __cache_free() chain does "virt_to_page()" on NUMA
regardless, through the
#ifdef CONFIG_NUMA
{
struct slab *slabp;
slabp = virt_to_slab(objp);
,,,
thing. The suggested patch obviously makes it do it _twice_: once to get
the cachep, once to get the slabp. But some simple re-organization would
make it do it just once, if we passed in the "struct page *" instead of
the "struct cachep" - since in the end, every single path into the real
core of the allocator does end up needing it.
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH] fs: fcntl_setlease defies lease_init assumptions
- From: Christoph Lameter <[email protected]>
- Re: [PATCH] fs: fcntl_setlease defies lease_init assumptions
- References:
- [PATCH] fs: fcntl_setlease defies lease_init assumptions
- From: Daniel Hokka Zakrisson <[email protected]>
- Re: [PATCH] fs: fcntl_setlease defies lease_init assumptions
- From: Linus Torvalds <[email protected]>
- Re: [PATCH] fs: fcntl_setlease defies lease_init assumptions
- From: "Pekka Enberg" <[email protected]>
- Re: [PATCH] fs: fcntl_setlease defies lease_init assumptions
- From: "Pekka Enberg" <[email protected]>
- Re: [PATCH] fs: fcntl_setlease defies lease_init assumptions
- From: Linus Torvalds <[email protected]>
- Re: [PATCH] fs: fcntl_setlease defies lease_init assumptions
- From: Pekka Enberg <[email protected]>
- Re: [PATCH] fs: fcntl_setlease defies lease_init assumptions
- From: Linus Torvalds <[email protected]>
- Re: [PATCH] fs: fcntl_setlease defies lease_init assumptions
- From: Pekka Enberg <[email protected]>
- Re: [PATCH] fs: fcntl_setlease defies lease_init assumptions
- From: Christoph Lameter <[email protected]>
- [PATCH] fs: fcntl_setlease defies lease_init assumptions
- Prev by Date: Re: [uml-devel] [PROBLEM] UML is killed by SIGALRM
- Next by Date: Re: How to read BIOS information
- Previous by thread: Re: [PATCH] fs: fcntl_setlease defies lease_init assumptions
- Next by thread: Re: [PATCH] fs: fcntl_setlease defies lease_init assumptions
- Index(es):
 |