Re: [PATCH] fix can_share_swap_page() when !CONFIG_SWAP

Hua Zhong wrote:

Hi,

can_share_swap_page() is used to check if the page has the last reference. This avoids allocating a new page for COW if it's the last page.

However, if CONFIG_SWAP is not set, can_share_swap_page() is defined as 0, thus always causes a copy for the last COW page. The below simple patch fixes it.

I'm not sure if it's the best fix. Maybe we should rename can_share_swap_page() and move it out of swapfile.c. Comments?


Looks like a good patch, nice catch. You should run it past Hugh but tend to

agree it would be nice to reuse the out of line can_share_swap_page,which would

fold beautifully with PageSwapCache a constant 0.

Nick
--

Send instant messages to your online friends http://au.messenger.yahoo.com-

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH] fix can_share_swap_page() when !CONFIG_SWAP
  - From: Hugh Dickins <[email protected]>

References:
- [PATCH] fix can_share_swap_page() when !CONFIG_SWAP
  - From: Hua Zhong <[email protected]>

Prev by Date: Re: [PATCH] Small patch to bloat-o-meter.
Next by Date: Re: sched_clock() uses are broken
Previous by thread: [PATCH] fix can_share_swap_page() when !CONFIG_SWAP
Next by thread: Re: [PATCH] fix can_share_swap_page() when !CONFIG_SWAP
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]