Re: [PATCH -mm] W1_CON: add W1 to depends

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 27, 2006 at 08:25:25AM -0700, Randy.Dunlap ([email protected]) wrote:
> On Thu, 27 Apr 2006 16:57:45 +0400 Evgeniy Polyakov wrote:
> 
> > On Wed, Apr 26, 2006 at 09:21:31PM -0700, Randy.Dunlap ([email protected]) wrote:
> > > From: Randy Dunlap <[email protected]>
> > > 
> > > W1_CON should depend on W1 also.
> > 
> > I have no problem with the patch, but does dependency absence introduce
> > some problems? This config option is only used when w1 is enabled.
> 
> Not quite true, or I wouldn't have seen a problem and sent a patch
> for it.
> With W1 disabled and doing 'make oldconfig', I got a prompt for
> 
>   Userspace communication over connector (W1_CON)? [Y/m/n]
> 
> which shouldn't happen.

I mean that it is asked to be enabled or not, but some compilation and
other logic is only turned on when w1 is enabled.

But you are right, it should not appear if w1 is not enabled.
I will take care of your patch, thank you, Randy.

> ---
> ~Randy

-- 
	Evgeniy Polyakov
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux