On Wed, 2006-04-26 at 17:52 +0200, Arjan van de Ven wrote:
> On Tue, 2006-04-25 at 15:00 -0700, Kristen Accardi wrote:
> > On Tue, 2006-04-25 at 08:16 +0200, Arjan van de Ven wrote:
> > > On Mon, 2006-04-24 at 15:50 -0700, Kristen Accardi wrote:
> > > > Don't call pci_enable_device from pciehp because the pcie port service driver
> > > > already does this.
> > >
> > > hmmmm shouldn't pci_enable_device on a previously enabled device just
> > > succeed? Sounds more than logical to me to make it that way at least...
> >
> > I can't think of any reason why not. Something like this what you had
> > in mind perhaps?
> >
> > ---
>
> the question then becomes if enable/disable should become "counting", eg
> enable twice disable once leaves enabled at count one....
ugh, no. 1) I think we should avoid adding more counting unless it's
absolutely necessary. 2) if a device calls pci_disable_device it should
always actually disable the device, because it is generally called in
drivers either when the device is being shutdown, or suspended.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
