Re: [PATCH] X86_NUMAQ build fix

[OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>]

Dave Hansen <haveblue@us.ibm.com> writes:

> Do you really need anything other than the Kconfig fix?  I thought that
> it alone would be a complete fix.

Yes. I thought I explained those...

>  #ifdef CONFIG_X86_NUMAQ
> -static void * xquad_portio = NULL;
> +/* hack to avoid using xquad_portio=NULL */
> +#undef outb_p
> +#define outb_p		outb_local_p
>  #endif

This fixes the following error.

make -C /devel/linux/works/linux-2.6 O=/devel/linux/works/linux-2.6-devron
  GEN    /devel/linux/works/linux-2.6-devron/Makefile
  CHK     include/linux/version.h
  Using /devel/linux/works/linux-2.6 as source for kernel
  CHK     include/linux/compile.h
  LD      vmlinux
  SYSMAP  System.map
  SYSMAP  .tmp_System.map
  Building modules, stage 2.
  LD      arch/i386/boot/setup
  CC      arch/i386/boot/compressed/misc.o
  OBJCOPY arch/i386/boot/compressed/vmlinux.bin
  GZIP    arch/i386/boot/compressed/vmlinux.bin.gz
/devel/linux/works/linux-2.6/arch/i386/boot/compressed/misc.c:125: error: static declaration of 'xquad_portio' follows non-static declaration
include2/asm/io.h:303: error: previous declaration of 'xquad_portio' was here
make[4]: *** [arch/i386/boot/compressed/misc.o] Error 1
make[4]: *** Waiting for unfinished jobs....
  MODPOST
make[3]: *** [arch/i386/boot/compressed/vmlinux] Error 2
make[2]: *** [bzImage] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [_all] Error 2
make: *** [all] Error 2

>  static int boot_cpu_logical_apicid;
> +#ifdef CONFIG_X86_NUMAQ
>  /* Where the IO area was mapped on multiquad, always 0 otherwise */
>  void *xquad_portio;
> -#ifdef CONFIG_X86_NUMAQ
>  EXPORT_SYMBOL(xquad_portio);
>  #endif

xquad_portio is needed to only X86_NUMAQ.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/