Re: [PATCH 2/5] Swapless V2: Add migration swap entries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 13 Apr 2006, Andrew Morton wrote:

> Christoph Lameter <[email protected]> wrote:
> >
> > +
> >  +	if (unlikely(is_migration_entry(entry))) {
> 
> Perhaps put the unlikely() in is_migration_entry()?
> 
> >  +		yield();
> 
> Please, no yielding.
> 
> _especially_ no unchangelogged, uncommented yielding.

Page migration is ongoing so its best to do something else first.

Add a comment?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux