Re: [PATCH 2/5] Swapless V2: Add migration swap entries

Christoph Lameter <[email protected]> wrote:
>
> +
>  +	if (unlikely(is_migration_entry(entry))) {

Perhaps put the unlikely() in is_migration_entry()?

>  +		yield();

Please, no yielding.

_especially_ no unchangelogged, uncommented yielding.

>  +		goto out;
>  +	}
>  +
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 2/5] Swapless V2: Add migration swap entries
    • From: Christoph Lameter <[email protected]>
  • Re: [PATCH 2/5] Swapless V2: Add migration swap entries
    • From: Christoph Lameter <[email protected]>

• References:
  • [PATCH 0/5] Swapless page migration V2: Overview
    • From: Christoph Lameter <[email protected]>
  • [PATCH 2/5] Swapless V2: Add migration swap entries
    • From: Christoph Lameter <[email protected]>

• Prev by Date: Re: [PATCH 0/5] Swapless page migration V2: Overview
• Next by Date: Re: [Ext2-devel] Re: [RFC][PATCH 0/3] ext3 percpu counter fixes to suppport for ext3 unsigned long type free blocks counter
• Previous by thread: [PATCH 2/5] Swapless V2: Add migration swap entries
• Next by thread: Re: [PATCH 2/5] Swapless V2: Add migration swap entries
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]