Re: [PATCH] de_thread: Don't confuse users do_each_thread.

On Tuesday, 11. April 2006 12:19, Oleg Nesterov wrote:
> On 04/11, Ingo Oeser wrote:
> >
> > While you are at it: Could you please avoid calculating current over 
> > and over again? 
> > 
> > Just calculate it once and use the task_struct pointer.
> 
> Ironically, de_thread() has 'tsk' parameter which is equal to 'current'.

That's the thing that made me doubt :-)

But thinking more about it: current cannot change within one thread, 
right? So all of this can be cleaned up.

I'll clean them up tonight and sent out a patch against current -mm.


Regards

Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH] de_thread: Don't confuse users do_each_thread.
  - From: [email protected] (Eric W. Biederman)

References:
- [PATCH rc1-mm] de_thread: fix deadlockable process addition
  - From: Oleg Nesterov <[email protected]>
- Re: [PATCH] de_thread: Don't confuse users do_each_thread.
  - From: Ingo Oeser <[email protected]>
- Re: [PATCH] de_thread: Don't confuse users do_each_thread.
  - From: Oleg Nesterov <[email protected]>

Prev by Date: Re: [PATCH] cleanup after deinlining patch 1/2
Next by Date: Re: [PATCH] fix de_thread() vs do_coredump() deadlock
Previous by thread: Re: [PATCH] de_thread: Don't confuse users do_each_thread.
Next by thread: Re: [PATCH] de_thread: Don't confuse users do_each_thread.
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]