Re: [PATCH] deinline some functions in aic7xxx drivers, save 80k of text

Stefan Richter wrote:
> Rolf Eike Beer wrote:
>> Denis Vlasenko wrote:
>>> I am leaving it up to maintainer to decide. After all, the driver
>>> is for multiple OSes, other OS may lack mdelay().
>> The comment says about multiple milliseconds sleeps which just don't happen.
> 
> Given what ah{c,d}_delay are (OS dependent wrappers) and how they are
> used (definitely not for multi-msec delays), they should just be changed
> into a #define ah{c,d}_delay(us) udelay(us) or into void inline
> ah{c,d}_delay(long us) {udelay(us);}.

I'd rather do a #define. Inlining simple functions is quite unneccessary
here.

Re multiplatform development: aic7{9,x}xx have ceased to be
multiplatfrom since the integration of scsi_transport_spi.
So I wouldn't worry too much about it.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke			[email protected]
SuSE Linux Products GmbH		S390 & zSeries
Maxfeldstraße 5				+49 911 74053 688
90409 Nürnberg				http://www.suse.de
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] deinline some functions in aic7xxx drivers, save 80k of text
    • From: Stefan Richter <[email protected]>

• References:
  • [PATCH] deinline some functions in aic7xxx drivers, save 80k of text
    • From: Denis Vlasenko <[email protected]>
  • Re: [PATCH] deinline some functions in aic7xxx drivers, save 80k of text
    • From: Rolf Eike Beer <[email protected]>
  • Re: [PATCH] deinline some functions in aic7xxx drivers, save 80k of text
    • From: Stefan Richter <[email protected]>

• Prev by Date: Re: [patch][rfc] quell interactive feeding frenzy
• Next by Date: Re: [PATCH rc1-mm 2/3] coredump: shutdown current process first
• Previous by thread: Re: [PATCH] deinline some functions in aic7xxx drivers, save 80k of text
• Next by thread: Re: [PATCH] deinline some functions in aic7xxx drivers, save 80k of text
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]