[Full quote and readded CC adresses. My fault, pressed wrong button] Denis Vlasenko wrote: > On Monday 10 April 2006 10:03, Rolf Eike Beer wrote: > > Am Montag, 10. April 2006 07:49 schrieben Sie: > > > On Monday 10 April 2006 08:44, Denis Vlasenko wrote: > > > > I also spotted two bugs in the process, patches > > > > for those will follow. > > > > > > ahd_delay(usec) is buggy. Just think how would it work > > > with usec == 1024*100 + 1... > > > > This is unneeded. The biggest argument this function is ever called with > > is 1000. > > I know. > > > I would suggest to delete this function completely. If one ever has to > > wait for a longer period mdelay() is the right function to call. > > I am leaving it up to maintainer to decide. After all, the driver > is for multiple OSes, other OS may lack mdelay(). The comment says about multiple milliseconds sleeps which just don't happen. Eike
Attachment:
pgpcpJodeRtAs.pgp
Description: PGP signature
- Follow-Ups:
- Re: [PATCH] deinline some functions in aic7xxx drivers, save 80k of text
- From: Arjan van de Ven <[email protected]>
- Re: [PATCH] deinline some functions in aic7xxx drivers, save 80k of text
- From: Stefan Richter <[email protected]>
- Re: [PATCH] deinline some functions in aic7xxx drivers, save 80k of text
- From: Denis Vlasenko <[email protected]>
- Re: [PATCH] deinline some functions in aic7xxx drivers, save 80k of text
- References:
- [PATCH] deinline some functions in aic7xxx drivers, save 80k of text
- From: Denis Vlasenko <[email protected]>
- [PATCH] deinline some functions in aic7xxx drivers, save 80k of text
- Prev by Date: Re: 2.6.16-rt11: Hires timer makes sleep wait far too long
- Next by Date: Re: + git-klibc-mktemp-fix.patch added to -mm tree
- Previous by thread: Re: [PATCH] deinline some functions in aic7xxx drivers, save 80k of text
- Next by thread: Re: [PATCH] deinline some functions in aic7xxx drivers, save 80k of text
- Index(es):
 |