Re: 2.6.17-rc1-mm1: KEXEC became SMP-only

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Zachary Amsden <[email protected]> wrote:
>
> Do weak symbols work with all tool chains?
> 

I hope so.  `grep weak */*.c'.

> >   
> >> 2) You don't need #ifdef SUBARCH_FUNC_FOO goo to do this (renaming 
> >> voyager_halt -> default)
> >>     
> >
> > Why would one need that?  Isn't it simply a matter of renaming
> > machine_halt() to subarch_machine_halt() everywhere?
> >   
> 
> No - if you rename machine_halt to subarch_machine_halt, you again can't 
> add a new subarch interface without changing all subarchitectures.  If I 
> add voyager_smp_bless_voyage(), I now need to add #define 
> visws_smp_bless_voyage default_smp_bless_voyage, ... or did you mean 
> subarch_machine_halt literally?

Yes, I meant subarch_machine_halt() literally.

> > I'm just looking for the simplest option here.  Eric has identified a code
> > maintainability problem - it'd be good to fix that, but we shouldn't add
> > runtime cost/complexity unless we actually gain something from it.
> >   
> 
> I think weak symbols are the best approach, if they indeed work with all 
> tool chains.

They do.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux