Re: delay_tsc(): inefficient delay loop (2.6.16-mm1)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/24/06, Andreas Mohr <[email protected]> wrote:
> +       loops += bclock;
[...]
> -       } while ((now-bclock) < loops);
> +       } while (now < loops);

Erm, aren't you introducing an overflow problem here?

if loops is 2^32-1, bclock is 1, the old version would execute the
proper number of times, the new one will blow out in one tick.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux