Re: [PATCH 9 of 18] ipath - char devices for diagnostics and lightweight subnet management

[Roland Dreier <rdreier@cisco.com>]

    Bryan> I'm a bit confused by your question.  We only have one SMA
    Bryan> implementation, which is in userspace.  The stuff that's in
    Bryan> our core driver is purely for supporting it.  That same
    Bryan> code is also used during diags, too, to let userspace send
    Bryan> and receive low-level packets.

We seem to be having a problem with the definition of an SMA.  I'm
talking about all the kernel code like the following (and similar
stuff for guidinfo, nodedescription, portinfo, pkeytable).

You must have nearly identical code in your userspace SMA, since it
also has to respond to the same SM queries, right?

I'm trying to understand why you can't get down to one implementation
of these functions.

 > +struct nodeinfo {
 > +	u8 base_version;
 > +	u8 class_version;
 > +	u8 node_type;
 > +	u8 num_ports;
 > +	__be64 sys_guid;
 > +	__be64 node_guid;
 > +	__be64 port_guid;
 > +	__be16 partition_cap;
 > +	__be16 device_id;
 > +	__be32 revision;
 > +	u8 local_port_num;
 > +	u8 vendor_id[3];
 > +} __attribute__ ((packed));
 > +
 > +static inline int recv_subn_get_nodeinfo(struct ib_smp *smp,
 > +					 struct ib_device *ibdev, u8 port)
 > +{
 > +	struct nodeinfo *nip = (struct nodeinfo *)&smp->data;
 > +	struct ipath_devdata *dd = to_idev(ibdev)->dd;
 > +	u32 vendor, boardid, majrev, minrev;
 > +
 > +	if (smp->attr_mod)
 > +		smp->status |= IB_SMP_INVALID_FIELD;
 > +
 > +	nip->base_version = 1;
 > +	nip->class_version = 1;
 > +	nip->node_type = 1;	/* channel adapter */
 > +	/*
 > +	 * XXX The num_ports value will need a layer function to get
 > +	 * the value if we ever have more than one IB port on a chip.
 > +	 * We will also need to get the GUID for the port.
 > +	 */
 > +	nip->num_ports = ibdev->phys_port_cnt;
 > +	/* This is already in network order */
 > +	nip->sys_guid = to_idev(ibdev)->sys_image_guid;
 > +	nip->node_guid = ipath_layer_get_guid(dd);
 > +	nip->port_guid = nip->sys_guid;
 > +	nip->partition_cap = cpu_to_be16(ipath_layer_get_npkeys(dd));
 > +	nip->device_id = cpu_to_be16(ipath_layer_get_deviceid(dd));
 > +	ipath_layer_query_device(dd, &vendor, &boardid, &majrev, &minrev);
 > +	nip->revision = cpu_to_be32((majrev << 16) | minrev);
 > +	nip->local_port_num = port;
 > +	nip->vendor_id[0] = 0;
 > +	nip->vendor_id[1] = vendor >> 8;
 > +	nip->vendor_id[2] = vendor;
 > +
 > +	return reply(smp);
 > +}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/