Re: [PATCH] Fix a potential NULL pointer deref in znet

["Jesper Juhl" <jesper.juhl@gmail.com>]

On 3/19/06, Al Viro <viro@ftp.linux.org.uk> wrote:
> On Sun, Mar 19, 2006 at 01:12:31AM +0100, Jesper Juhl wrote:
> >
> > The coverity checker spotted that we dereference a pointer before we check it
> > for NULL in drivers/net/znet.c::znet_interrupt().
> > This fixes the issue.
>
> The hell it does.  Either interrupt really isn't shared, in which case
> this check should be simply removed, or it can be shared, in which case
> the code is still buggered.
>
> Please, stop pulling Bunk - _think_ before submitting "make <program> STFU"
> patches.
>

Believe it or not,  but I actually do try to think about the patches I submit.
I make mistakes sometimes and I don't know all the code in as much
depth as I would like, but I do try to help out the best I can.

I appreciate feedback on the work I do, and I try to improve based on
it - this means I also value your feedback although I must say I
dislike your tone.

I'll stare at the code some more and try to come up with a better
patch after I've had some sleep.

--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/