Re: [PATCH] Fix a potential NULL pointer deref in znet

On Sun, Mar 19, 2006 at 01:12:31AM +0100, Jesper Juhl wrote:
> 
> The coverity checker spotted that we dereference a pointer before we check it
> for NULL in drivers/net/znet.c::znet_interrupt().
> This fixes the issue.

The hell it does.  Either interrupt really isn't shared, in which case
this check should be simply removed, or it can be shared, in which case
the code is still buggered.

Please, stop pulling Bunk - _think_ before submitting "make <program> STFU"
patches.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Fix a potential NULL pointer deref in znet
    • From: "Jesper Juhl" <[email protected]>

• References:
  • [PATCH] Fix a potential NULL pointer deref in znet
    • From: Jesper Juhl <[email protected]>

• Prev by Date: [PATCH] Fix a potential NULL pointer deref in znet
• Next by Date: Re: OOPS: 2.6.16-rc6 cpufreq_conservative
• Previous by thread: [PATCH] Fix a potential NULL pointer deref in znet
• Next by thread: Re: [PATCH] Fix a potential NULL pointer deref in znet
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]