[PATCH] unshare: Error if passed unsupported flags

This patch does a bare bones trivial patch to ensure we always
get -EINVAL on the unsupported cases for sys_unshare.  If this
goes in before 2.6.16 it allows us to forward compatible with
future applications using sys_unshare.

Signed-off-by: Eric W. Biederman <[email protected]>


---

 kernel/fork.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

46868b4b6ebeb9042dded68a6f6301ffe06820c9
diff --git a/kernel/fork.c b/kernel/fork.c
index 46060cb..411b10d 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -1535,6 +1535,12 @@ asmlinkage long sys_unshare(unsigned lon
 	struct sem_undo_list *new_ulist = NULL;
 
 	check_unshare_flags(&unshare_flags);
+       
+	/* Return -EINVAL for all unsupported flags */
+	err = -EINVAL;
+	if (unshare_flags & ~(CLONE_THREAD|CLONE_FS|CLONE_NEWNS|CLONE_SIGHAND|
+				CLONE_VM|CLONE_FILES|CLONE_SYSVSEM))
+		goto bad_unshare_out;
 
 	if ((err = unshare_thread(unshare_flags)))
 		goto bad_unshare_out;
-- 
1.2.4.g2d33

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] unshare: Error if passed unsupported flags
    • From: Janak Desai <[email protected]>

• References:
  • [PATCH] unshare: Cleanup up the sys_unshare interface before we are committed.
    • From: [email protected] (Eric W. Biederman)
  • [PATCH] unshare: Use rcu_assign_pointer when setting sighand
    • From: [email protected] (Eric W. Biederman)
  • Re: [PATCH] unshare: Use rcu_assign_pointer when setting sighand
    • From: Oleg Nesterov <[email protected]>
  • Re: [PATCH] unshare: Use rcu_assign_pointer when setting sighand
    • From: Andrew Morton <[email protected]>

• Prev by Date: [patch 0/2] sys_setitimer and sys_alarm hotfixes
• Next by Date: Re: [PATCH] unshare: Error if passed unsupported flags
• Previous by thread: [PATCH] implement unshare(CLONE_SIGHAND) for single-thread case
• Next by thread: Re: [PATCH] unshare: Error if passed unsupported flags
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]