Re: [PATCH] unshare: Use rcu_assign_pointer when setting sighand

"Eric W. Biederman" wrote:
> 
> @@ -1573,7 +1573,7 @@ asmlinkage long sys_unshare(unsigned lon
> 
>                 if (new_sigh) {
>                         sigh = current->sighand;
> -                       current->sighand = new_sigh;
> +                       rcu_assign_pointer(current->sighand, new_sigh);
>                         new_sigh = sigh;
>                 }

Isn't it better to just replace this code with
'BUG_ON(new_sigh != NULL)' ?

It is never executed, but totally broken, afaics.
task_lock() has nothing to do with ->sighand changing.

Oleg.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] unshare: Use rcu_assign_pointer when setting sighand
    • From: Andrew Morton <[email protected]>

• References:
  • [PATCH] unshare: Cleanup up the sys_unshare interface before we are committed.
    • From: [email protected] (Eric W. Biederman)
  • [PATCH] unshare: Use rcu_assign_pointer when setting sighand
    • From: [email protected] (Eric W. Biederman)

• Prev by Date: Re: BUG: atomic counter underflow [Was: 2.6.16-rc6-mm1]
• Next by Date: Re: Idea: Automatic binary driver compiling system
• Previous by thread: Re: [PATCH] unshare: Use rcu_assign_pointer when setting sighand
• Next by thread: Re: [PATCH] unshare: Use rcu_assign_pointer when setting sighand
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]