Re: [PATCH 10 of 20] ipath - support for userspace apps using core driver

On Thu, 2006-03-16 at 17:27 +0000, Hugh Dickins wrote:

> There's no need to do a get_page after the allocation and a put_page
> before the free (though you could, it's just extra unnecessary work):
> the allocation comes with a reference count of 1, the free frees up
> that last remaining reference count of 1 (as Andrew explained more
> lucidly elsewhere in his mail).

All right.  I followed your advice and you are indeed correct; the added
get_page and put_page were not necessary; __GFP_COMP alone did the
trick.

Thanks,

	<b

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • Re: [PATCH 10 of 20] ipath - support for userspace apps using core driver
    • From: Roland Dreier <[email protected]>
  • Re: [PATCH 10 of 20] ipath - support for userspace apps using core driver
    • From: "Bryan O'Sullivan" <[email protected]>
  • Re: [PATCH 10 of 20] ipath - support for userspace apps using core driver
    • From: Roland Dreier <[email protected]>
  • Re: [PATCH 10 of 20] ipath - support for userspace apps using core driver
    • From: "Bryan O'Sullivan" <[email protected]>
  • Re: [PATCH 10 of 20] ipath - support for userspace apps using core driver
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH 10 of 20] ipath - support for userspace apps using core driver
    • From: "Bryan O'Sullivan" <[email protected]>
  • Re: [PATCH 10 of 20] ipath - support for userspace apps using core driver
    • From: Roland Dreier <[email protected]>
  • Re: [PATCH 10 of 20] ipath - support for userspace apps using core driver
    • From: "Bryan O'Sullivan" <[email protected]>
  • Re: [PATCH 10 of 20] ipath - support for userspace apps using core driver
    • From: Roland Dreier <[email protected]>
  • Re: [PATCH 10 of 20] ipath - support for userspace apps using core driver
    • From: "Bryan O'Sullivan" <[email protected]>
  • Re: [PATCH 10 of 20] ipath - support for userspace apps using core driver
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH 10 of 20] ipath - support for userspace apps using core driver
    • From: "Bryan O'Sullivan" <[email protected]>
  • Re: [PATCH 10 of 20] ipath - support for userspace apps using core driver
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH 10 of 20] ipath - support for userspace apps using core driver
    • From: "Bryan O'Sullivan" <[email protected]>
  • Re: [PATCH 10 of 20] ipath - support for userspace apps using core driver
    • From: Hugh Dickins <[email protected]>

• Prev by Date: Re: [Bug? Report] kref problem
• Next by Date: Re: [Bug? Report] kref problem
• Previous by thread: Re: [PATCH 10 of 20] ipath - support for userspace apps using core driver
• Next by thread: Re: [PATCH 10 of 20] ipath - support for userspace apps using core driver
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]