Hi Eugene,
Eugene Teo wrote:
> failed:
>- kfree(parse);
>- kfree(hw_priv);
>+ if (parse)
>+ kfree(parse);
>+ if (hw_priv)
>+ kfree(hw_priv);
> prism2_release((u_long)link);
> return ret;
> }
>
>
I don't think those if's are needed, since the kfree code already does:
void kfree(const void *objp)
{
if (unlikely(!objp))
return;
...
}
But if you really want to use it, I suggest using if (likely
(!<pointer>)) there to hint gcc of a possible optimization.
Cheers,
Felipe Damasio
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
