Re: Fix hostap_cs double kfree

[Felipe W Damasio <felipewd@terra.com.br>]

    Hi Eugene,

Eugene Teo wrote:

>  failed:
>-	kfree(parse);
>-	kfree(hw_priv);
>+	if (parse)
>+		kfree(parse);
>+	if (hw_priv)
>+		kfree(hw_priv);
> 	prism2_release((u_long)link);
> 	return ret;
> }
>  
>
    I don't think those if's are needed, since the kfree code already does:

void kfree(const void *objp)
{
        if (unlikely(!objp))
                return;
...
}

    But if you really want to use it, I suggest using if (likely
(!<pointer>)) there to hint gcc of a possible optimization.

    Cheers,

Felipe Damasio
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/