Re: [2.6 patch] net/decnet/dn_route.c: fix inconsequent NULL checking

Adrian Bunk <[email protected]> wrote:
> The Coverity checker noted this inconsequent NULL checking in
> dnrt_drop().
> 
> Since all callers ensure that NULL isn't passed, we can simply remove 
> the check.

Ack.

In fact it's pointless even if the caller didn't check as dst_release
checks it anyway.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [2.6 patch] net/decnet/dn_route.c: fix inconsequent NULL checking
    • From: Adrian Bunk <[email protected]>

• Prev by Date: Re: [2.6 patch] crypto/aes.c: array overrun
• Next by Date: Re: [2.6.16-rc5-git13] Xorg.log difference
• Previous by thread: [2.6 patch] net/decnet/dn_route.c: fix inconsequent NULL checking
• Next by thread: Re: [2.6 patch] net/decnet/dn_route.c: fix inconsequent NULL checking
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]