Re: [PATCH 9 of 20] ipath - char devices for diagnostics and lightweight subnet management

    Bryan> It's read outside of this file, without a lock held.

I missed the other reference in another patch.  But the central point
still stands: if all you do is atomic_set() and atomic_read(), then
using atomic_t doesn't buy you anything.  Just look at what
atomic_read() expands to -- using it isn't protecting you against
anything, so either you have a race, or you were safe without
atomic_t.  The only point to atomic_t is so that you can safely do
read-modify-write things like atomic_inc().

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- [PATCH 9 of 20] ipath - char devices for diagnostics and lightweight subnet management
  - From: "Bryan O'Sullivan" <[email protected]>
- Re: [PATCH 9 of 20] ipath - char devices for diagnostics and lightweight subnet management
  - From: Roland Dreier <[email protected]>
- Re: [PATCH 9 of 20] ipath - char devices for diagnostics and lightweight subnet management
  - From: "Bryan O'Sullivan" <[email protected]>

Prev by Date: Re: [PATCH] EDAC: core EDAC support code
Next by Date: Re: [RFC] Badness in __mutex_unlock_slowpath with XFS stress tests
Previous by thread: Re: [PATCH 9 of 20] ipath - char devices for diagnostics and lightweight subnet management
Next by thread: [PATCH 6 of 20] ipath - chip initialisation code
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]