Re: [PATCH 9 of 20] ipath - char devices for diagnostics and lightweight subnet management

OK, now I can see the change you made:

 > +atomic_t ipath_sma_alive;
 > +DEFINE_SPINLOCK(ipath_sma_lock);	/* SMA receive */

So why is ipath_sma_alive an atomic_t (and why isn't it static)?
You never modify ipath_sma_alive outside of your spinlock, so I don't
see what having it be atomic buys you.

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH 9 of 20] ipath - char devices for diagnostics and lightweight subnet management
  - From: "Bryan O'Sullivan" <[email protected]>

References:
- [PATCH 9 of 20] ipath - char devices for diagnostics and lightweight subnet management
  - From: "Bryan O'Sullivan" <[email protected]>

Prev by Date: Re: [PATCH 9 of 20] ipath - char devices for diagnostics and lightweight subnet management
Next by Date: [PATCH 5 of 20] ipath - support for PCI Express devices
Previous by thread: [PATCH 9 of 20] ipath - char devices for diagnostics and lightweight subnet management
Next by thread: Re: [PATCH 9 of 20] ipath - char devices for diagnostics and lightweight subnet management
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]