On Mon, 6 Mar 2006, Mike Christie wrote: > - buffer = kmalloc(32, GFP_KERNEL | SR_GFP_DMA(cd)); > + buffer = kzalloc(32, GFP_KERNEL | SR_GFP_DMA(cd)); > if (!buffer) > return -ENOMEM; > > - memset(&cgc, 0, sizeof(struct packet_command)); ... > - buffer = kmalloc(32, GFP_KERNEL | SR_GFP_DMA(cd)); > + buffer = kzalloc(32, GFP_KERNEL | SR_GFP_DMA(cd)); > if (!buffer) > return -ENOMEM; > > - memset(&cgc, 0, sizeof(struct packet_command)); > When someone converted the *buffer* allocation to kzalloc they > also removed the the memset for the *packet_cmmand* struct. > > The > > memset(&cgc, 0, sizeof(struct packet_command)); > > should be added back I think. Good eyes. I bet that's it. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: Slab corruption in 2.6.16-rc5-mm2
- From: James Bottomley <[email protected]>
- Re: Slab corruption in 2.6.16-rc5-mm2
- References:
- Slab corruption in 2.6.16-rc5-mm2
- From: Jesper Juhl <[email protected]>
- Re: Slab corruption in 2.6.16-rc5-mm2
- From: "Jesper Juhl" <[email protected]>
- Re: Slab corruption in 2.6.16-rc5-mm2
- From: "Jesper Juhl" <[email protected]>
- Re: Slab corruption in 2.6.16-rc5-mm2
- From: Linus Torvalds <[email protected]>
- Re: Slab corruption in 2.6.16-rc5-mm2
- From: "Jesper Juhl" <[email protected]>
- Re: Slab corruption in 2.6.16-rc5-mm2
- From: Linus Torvalds <[email protected]>
- Re: Slab corruption in 2.6.16-rc5-mm2
- From: Linus Torvalds <[email protected]>
- Re: Slab corruption in 2.6.16-rc5-mm2
- From: Linus Torvalds <[email protected]>
- Re: Slab corruption in 2.6.16-rc5-mm2
- From: "Jesper Juhl" <[email protected]>
- Re: Slab corruption in 2.6.16-rc5-mm2
- From: Andrew Morton <[email protected]>
- Re: Slab corruption in 2.6.16-rc5-mm2
- From: "Jesper Juhl" <[email protected]>
- Re: Slab corruption in 2.6.16-rc5-mm2
- From: Mike Christie <[email protected]>
- Slab corruption in 2.6.16-rc5-mm2
- Prev by Date: Re: [RFC][PATCH] Experimental enhanced NTP error accounting patch
- Next by Date: Re: [PATCH] udf: fix uid/gid options and add uid/gid=ignore and forget options
- Previous by thread: Re: Slab corruption in 2.6.16-rc5-mm2
- Next by thread: Re: Slab corruption in 2.6.16-rc5-mm2
- Index(es):
 |