On Monday March 6, [email protected] wrote:
>
> In general your patch is still does what mine do, so I will be happy if
> any of this is commited mainstream. In future, please, keep the
> reference to original authors, this will also make sure that I'm on CC
> if something goes wrong.
Sorry: which 'original author' did I miss ?
> >
> > + if (dentry->d_sb->s_root == NULL &&
> > + (parent == NULL ||
> > + parent->d_sb != dentry->d_sb))
> > + continue;
> <<<<
> - we select some dentries in select_parent and then try to prune N
> dentries. But this can be other N dentries :/ It's not the problem with
> your code, but... adding 'parent' arg to prune_dcache() makes me feel
> the same as with 'found' arg: you don't use it actually right way. You
> don't prune only its children, you see? It is better to pass 'sb' arg then.
>
That's a valid point. I should be passing 'sb'.
Thanks,
NeilBrown
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
