Re: [PATCH] 2.6.16-rc5-mm2 mpage_readpages() cleanup

Andrew Morton wrote:

Badari Pulavarty <[email protected]> wrote:

Instead of passing validity of block mapping, do_mpage_readpage() can figure it out using buffer_mapped(). This will reduce one

un-needed argument passing.

Is buffer_mapped() the correct flag to use?  Remember that get_block() can
validly return a !buffer_mapped() bh over a file hole.

Yes. Currently the code which handles hole can only deal with a single block at a time.

All I am trying to do is,  find out when to do next getblock() call.

Either way, there should be a comment in there explaining the protocol,
please.

Will do.

Thanks,
Badari



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] 2.6.16-rc5-mm2 mpage_readpages() cleanup
    • From: Badari Pulavarty <[email protected]>
  • Re: [PATCH] 2.6.16-rc5-mm2 mpage_readpages() cleanup
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: PCI-DMA: Out of IOMMU space on x86-64 (Athlon64x2), with solution
• Next by Date: Re: Slab corruption in 2.6.16-rc5-mm2
• Previous by thread: Re: [PATCH] 2.6.16-rc5-mm2 mpage_readpages() cleanup
• Next by thread: Re: [PATCH] 2.6.16-rc5-mm2 mpage_readpages() cleanup
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]