Re: [PATCH] Generic hardware RNG support

[Michael Buesch <mbuesch@freenet.de>]

On Wednesday 01 March 2006 03:57, you wrote:
> > Hi, I'll email you the patchset off-list so you can look at the API
> > and write the bcm43xx driver against it.  They are a few months old  
> > and
> > need updating to 2.6.latest and it is on my 2.6.18 TODO. If you  
> > search the
> > archives there were a few small issues left such as separating out  
> > all the
> > x86 stuff into separate amd, via, and intel code instead of having  
> > a single
> > file.
> 
> Are the patches in any state to include in -mm?

I don't think so. In fact, I think they are lacking important
functionality, which is present in my patches.
What about this: I change my patches to split the whole RNG
code into a "core" and the various drivers. That is basically
what Deepak Saxena's patches do and mine not, yet.
Support for multiple RNGs in the system at the same time is missing
in Deepak Saxena's patches. This support is important for the
bcm43xx driver, for example.
The rng_operations structure (which I renamed to struct hwrng)
lacks a few (more or less) important members. The n_bytes field
for example. Not every driver is able to generate sizeof(u32) bytes
for every read_data. (That is the case for bcm43xx and others).
The init and cleanup callbacks are less important, athough they
are often convenient. So I would like to have them, too.

To summerize, I'd like to change my patches:
- Split it into core + drivers.
- Get rid of the ugly struct pci_dev *dev; in struct hwrng.
- Remove the dependency for PCI from the core.
- Maybe remove some of the redundant asserts the some hardware routines.
- Fix a few minor bugs I spotted after submitting. Oops :D

and re-submit them to andrew.
I think this is also less work than resyncing Deepak Saxena's patches.

-- 
Greetings Michael.

Attachment: pgp8pL59ZDK56.pgp
Description: PGP signature