2.6.16-rc3 macromedia flash regression...

[Ernst Herzberg <list-lkml@net4u.de>]

.... or not regession, that's the question.

2.6.16-rc2 works without problems.

With -rc3 a .swf that opens a ip connection back to the server takes ages to 
load. strace shows that the player hangs for long times in select().

Digging through the changelog brings up

commit 643a654540579b0dcc7a206a4a7475276a41aff0
Author: Andrew Morton <akpm@osdl.org>
Date:   Sat Feb 11 17:55:52 2006 -0800

    [PATCH] select: fix returned timeval


Reverting the patch partial like

--- lx-2.6.16-rc3/fs/select.c   2006-02-17 04:35:10.000000000 +0100
+++ lx-2.6.16-rc3.old/fs/select.c       2006-02-17 04:44:00.000000000 +0100
@@ -404,8 +404,6 @@ asmlinkage long sys_select(int n, fd_set
                        goto sticky;
                rtv.tv_usec = jiffies_to_usecs(do_div((*(u64*)&timeout), HZ));
                rtv.tv_sec = timeout;
-               if (timeval_compare(&rtv, &tv) < 0)
-                       rtv = tv;
                if (copy_to_user(tvp, &rtv, sizeof(rtv))) {
 sticky:
                        /*
@@ -471,8 +469,6 @@ asmlinkage long sys_pselect7(int n, fd_s
                rts.tv_nsec = jiffies_to_usecs(do_div((*(u64*)&timeout), HZ)) 
*
                                                1000;
                rts.tv_sec = timeout;
-               if (timespec_compare(&rts, &ts) < 0)
-                       rts = ts;
                if (copy_to_user(tsp, &rts, sizeof(rts))) {
 sticky:
                        /*

----------------------

fixed that, the player works again in normal speed.

The player is the newest from macromedia (7.0.61.0, gentoo ebuild), binary 
only of course:( Reading the patch and the documentation of select() i think 
the player is buggy... but works until 2.6.16-rc3

So what is your opinion? I think, macromedia should fix the player... 

Thanks 

<earny/>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/