Re: [patch 0/2] fix perf. bug in wake-up load balancing for aim7 and db workload

[Andrew Morton <akpm@osdl.org>]

"Chen, Kenneth W" <kenneth.w.chen@intel.com> wrote:
>
> Commit d7102e95b7b9c00277562c29aad421d2d521c5f6 in linus's git tree
> 
> [PATCH] sched: filter affine wakeups
> From: Nick Piggin <nickpiggin@yahoo.com.au>
> Track the last waker CPU, and only consider wakeup-balancing if there's a
> match between current waker CPU and the previous waker CPU.  This ensures
> that there is some correlation between two subsequent wakeup events before
> we move the task.  Should help random-wakeup workloads on large SMP
> systems, by reducing the migration attempts by a factor of nr_cpus.
> 
> 
> Apparently caused more than 10% performance regression for aim7 benchmark.

Post-mortem time.   Why was it merged?

This patch was added to -mm on 8 November 2006.  Was merged into mainline
12 January 2006.  That's two months in -mm and one month in mainline.

I don't think it's reasonable to stretch the latency of scheduler patches
to even longer than three months and I doubt if that'll solve the problem.

Oh well, at least we found it.

> 
> We should back out the above commit and add a sysctl variable to control the
> behavior of load balancing in wake up path, so user can dynamically select
> a mode that best fit for the workload environment.  And kernel can achieve
> best performance in two extreme ends of incompatible workload environments.

Well I don't see any benchmark numbers in the original patch.  Just an
assertion that it "should" help something.

I'm more inclined to revert it and not add the sysctl (ugh) until we have a
good reason to do so.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/