Re: [RFC][PATCH 3/5] Virtualization/containers: UTSNAME

I am disturbed by the introduction of #defines like current_vps() and
vps_utsname.

Magic lower case #defines are usually a bad idea.  

These defines hide the cost of the operations you are performing.
At that point you might as well name the thing system_utsname
so you don't have to change the code.  

And of course you failed to change several references to
system_utsname.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [RFC][PATCH 3/5] Virtualization/containers: UTSNAME
    • From: Kirill Korotaev <[email protected]>

• References:
  • [RFC][PATCH 1/5] Virtualization/containers: startup
    • From: Kirill Korotaev <[email protected]>
  • [RFC][PATCH 3/5] Virtualization/containers: UTSNAME
    • From: Kirill Korotaev <[email protected]>

• Prev by Date: Re: [PATCH 1/5] cpuset memory spread basic implementation
• Next by Date: Re: [PATCH 1/5] cpuset memory spread basic implementation
• Previous by thread: [RFC][PATCH 3/5] Virtualization/containers: UTSNAME
• Next by thread: Re: [RFC][PATCH 3/5] Virtualization/containers: UTSNAME
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]